This repository was archived by the owner on Jan 16, 2018. It is now read-only.
[feature/bug fix] Support for ES6 modules transpiled by babel >= 6#23
Open
kkwiatkowski wants to merge 1 commit intowebpack:masterfrom
Open
[feature/bug fix] Support for ES6 modules transpiled by babel >= 6#23kkwiatkowski wants to merge 1 commit intowebpack:masterfrom
kkwiatkowski wants to merge 1 commit intowebpack:masterfrom
Conversation
Author
|
Any feedback about this pull request, @sokra? |
Author
|
Is there any chance to not let it die, @sokra? |
Member
|
Sorry, webpack/core is no longer used by webpack. webpack 2 now uses https://github.com/webpack/loader-runner and it supports loaders exporting ES6 https://github.com/webpack/loader-runner/blob/master/lib/loadLoader.js#L31 I'm willing to merge your changes, but they need to be compatible with the webpack 2 format: export default function(source) { return source; /* normal */ }
export function pitch(...) { /* pitch */ }Your PR doesn't implement the You could move the |
Author
|
Ok, I'll do that. Thanks for answer 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When you use Babel 6 to transpile code, the exports varies a bit from regular CommonJS exports.
And because of that loaders written in ES6, transpiled by Babel 6 are not handled correctly in Webpack.
This is also related with: #webpack/issues/2047
Pull request
I don't know if this is proper place for that, but I hope it's fine.
Would be great, if it's treated as patch, if merged.